ci(github): migrate to JSON-based NuGet versioning strategy#35
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee7ccfb312
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| jobs: | ||
| publish: | ||
| uses: LayeredCraft/devops-templates/.github/workflows/publish-preview.yml@main |
There was a problem hiding this comment.
This workflow now depends on LayeredCraft/devops-templates/...@main, so every publish run will fail with “workflow was not found” whenever main does not yet contain publish-preview.yml/publish-release.yml (the current state that this PR itself calls out as an external dependency). Because this repo no longer has a fallback build/publish workflow, that makes main pushes and release tags non-runnable until the upstream branch state matches; pinning to a released tag/SHA that already contains these files avoids that breakage.
Useful? React with 👍 / 👎.
1 participant
🚀 Pull Request
📋 Summary
Migrates
LayeredCraft.StructuredLoggingfrom the MSBuildVersionPrefixpublish approach to the new JSON-based versioning strategy introduced in devops-templates#21.eng/package-versioning.json— version manifest withsinglestrategy, prefix1.1.8publish-preview.yaml— triggers on push tomain, publishes1.1.8-preview.<runNumber>publish-release.yaml— triggers on tagv*, validates tag against manifest, publishes stable version and creates GitHub Releasebuild.yaml— replaced by the two new caller workflows aboveLayeredCraft.StructuredLogging.slnx— reflects new workflow files and addseng/package-versioning.jsonto Solution Items✅ Checklist
🧪 Related Issues or PRs
Depends on LayeredCraft/devops-templates#21 — merge that first.
💬 Notes for Reviewers
Caller workflows reference
@mainondevops-templates, so devops-templates#21 must be merged before this PR is merged — otherwise the reusable workflows won't resolve.To test after both are merged: go to Actions →
Publish Preview→Run workflowonmain.Directory.Build.propsstill hasVersionPrefix— it's no longer used by CI but can be cleaned up in a follow-up once the new approach is validated.